Fix for #25 (and afterAnimate) #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mation removed mentioning of the now unused dependency fbjs
Collaborator
|
@xehpuk your commit are absolutely great. Only one thing. Could you reimplement |
Contributor
Author
|
Phew, not sure how to do it or if it's even possible without using a |
Collaborator
|
At the end, the solution, promisify setTimeout, looks more tricky. Thanks for take your time on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
animateScrollpreviously returned immediately which resulted inupdateHistoryandafterAnimateto run before the animation. It nor returns aPromisewhich is resolved when the animation ends and is rejected if there isn't an element with the given ID.This previously was a warning emitted by
fbjs(and its last usage). So now it's kicked out of the readme.The
package-lock.jsonshould be committed into source repositories.